Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate pavelkalinnikov as reviewer #59

Closed
tbg opened this issue May 26, 2023 · 4 comments
Closed

Nominate pavelkalinnikov as reviewer #59

tbg opened this issue May 26, 2023 · 4 comments
Assignees

Comments

@tbg
Copy link
Collaborator

tbg commented May 26, 2023

I'd like to nominate @pavelkalinnikov as a reviewer (in the sense of the etcd community guidelines1) for etcd-io/raft starting in mid-July 20232

As of mid-April, Pavel is recognized as an etcd/etcd-io member owing to his contributions to etcd-io/raft. As you can see from the references within and his activity since, Pavel has been very active on the raft codebase, fixing bugs, adding new functionality and documentation, and is starting to reflect on the future direction of the library as well (e.g. 3). As Pavel's co-worker on the Replication team at Cockroach Labs, I can attest to his intimacy with both consensus algorithms and their real-world deployment at scale and further foster his involvement with our community.

cc @ahrtr @mitake @ptabor @serathius @spzala


2023-05-31: edited to reflect outcome of discussion among maintainers about how to apply the community guidelines1

Footnotes

  1. https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/community-membership.md 2 3

  2. at which he will clear the three-month minimum membership duration stipulated in 1

  3. https://github.com/etcd-io/raft/issues/64

@tbg tbg mentioned this issue May 26, 2023
@ahrtr ahrtr changed the title Nominate pavelkalinnikov as approver Nominate pavelkalinnikov as reviewer May 31, 2023
@ahrtr
Copy link
Member

ahrtr commented Jun 1, 2023

I am definitely supportive on this. Pavel has already demonstrated great expertise on raft, and Tobias’s endorsement is definitely a big big plus. Thanks @pavelkalinnikov for your great contribution, and also thanks @tbg for your leadership in raft.

@spzala
Copy link
Member

spzala commented Jun 1, 2023

+1 @pavelkalinnikov congratulations and thank you for your ongoing contributions to the project! @tbg thank you so much for your years of leadership in the Raft area!

@tbg tbg assigned tbg and unassigned ahrtr Jun 21, 2023
This was referenced Jul 21, 2023
tbg added a commit to tbg/raft that referenced this issue Jul 21, 2023
As discussion in etcd-io#59.

Signed-off-by: Tobias Grieger <tobias.b.grieger@gmail.com>
@ahrtr
Copy link
Member

ahrtr commented Jul 21, 2023

Completed by #87

@ahrtr ahrtr closed this as completed Jul 21, 2023
@pav-kv
Copy link
Contributor

pav-kv commented Jul 26, 2023

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants