Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce old Docsy-overrides where needed/wanted #813

Open
nate-double-u opened this issue Mar 22, 2024 · 2 comments
Open

Reintroduce old Docsy-overrides where needed/wanted #813

nate-double-u opened this issue Mar 22, 2024 · 2 comments

Comments

@nate-double-u
Copy link
Contributor

nate-double-u commented Mar 22, 2024 •
edited
Loading

Follow up to #803, it looks like we've lost the old version warning banner. Do we still want/need it? if so, we should reintroduce it.

Screenshot 2024-03-22 at 2 52 49 PM

There are several overrides that got dropped and could be reintroduced. The majority of them can be found in PR cncf/docsy#2
@nate-double-u
Copy link
Contributor Author

The banner code can be found here: https://github.com/cncf/docsy/blob/etcd.io/layouts/partials/version-banner.html

@nate-double-u nate-double-u changed the title Old version banner removed in docsy upgrade Reintroduce old-Docsy overrides where needed/wanted Mar 22, 2024
@nate-double-u nate-double-u changed the title Reintroduce old-Docsy overrides where needed/wanted Reintroduce old Docsy-overrides where needed/wanted Mar 22, 2024
@Sadamingh
Copy link
Contributor

Hi @nate-double-u, if the banner is needed, I can start to work on these. Need information on which versions I have to add those banners. Also, enabling the banners will possibly remove these issues like #837.

/cc @jmhbnz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nate-double-u @Sadamingh