Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPL-1160: "Done" button not locking in 'Add Payments' and 'Add Details' processes when only a value is entered in 'Actual Payment' without losing focus #320

Closed
brunoromerosmf opened this issue Feb 27, 2024 · 1 comment · Fixed by #408
Assignees
Labels
bug Something isn't working

Comments

@brunoromerosmf
Copy link
Collaborator

Error's description

An issue occurs in popups related to the 'add payment' process within the 'transactions' tab of the 'financial account' window, and in the 'add details' process of the 'payment in' window. When a value is entered in the 'actual payment' field and an attempt is made to save without losing focus from the field, incorrect behaviors are observed:

  1. In the first scenario, a 'payment in' is created with a value of 0 and without lines, allowing the transaction to be processed.
  2. In the second scenario, even though the 'done' button does not lock, when attempting to save, the system fails to save and displays an error. However, the appropriate behavior would be for the 'done' button to lock.

Steps to reproduce the error

  1. For the first case 'add payment':
    a. Navigate to the 'financial account' window.
    b. Go to the 'transactions' tab.
    c. Create a new transaction.
    d. Click on the '+' button next to the 'payment' field.
    e. Enter a value in the 'actual payment' field.
    f. Attempt to save by clicking 'done' without shifting focus from the 'actual payment' field.
    g. The transaction is as follows:
    image
    The payment in is a follows:
    image

  2. For the second case 'add details':
    a. Create a new 'payment in' with no value in the corresponding window. (Remember to set a partner)
    b. Click on the 'add details' button.
    c. Repeat the steps of entering a value in 'actual payment' and attempting to save without shifting focus, as in the first case.
    image

Expected behavior

The expected behavior in both scenarios is that the 'done' button should lock while the 'actual payment' field is in focus with a value entered. This should prevent the creation of erroneous transactions (with a value of 0 and without lines) and ensure that the user cannot process the transaction until the payment is fully completed and the focus is shifted from the 'actual payment' field.

Affected Version

Etendo core 23.3.2

@brunoromerosmf brunoromerosmf added the bug Something isn't working label Feb 27, 2024
sebastianbarrozo added a commit that referenced this issue May 22, 2024
sebastianbarrozo added a commit that referenced this issue May 22, 2024
sebastianbarrozo added a commit that referenced this issue Jul 12, 2024
sebastianbarrozo added a commit that referenced this issue Jul 12, 2024
valeg-etendo added a commit that referenced this issue Jul 12, 2024
Issue #320: Check total amount on done in Add Details pop-up
@valeg-etendo
Copy link
Collaborator

Important

Bug resolved in version 24.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants