Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonpayable function heuristic is broken for vyper 0.2.5 #781

Closed
iamdefinitelyahuman opened this issue Oct 1, 2020 · 0 comments · Fixed by #784
Closed

Nonpayable function heuristic is broken for vyper 0.2.5 #781

iamdefinitelyahuman opened this issue Oct 1, 2020 · 0 comments · Fixed by #784
Labels
bug Something isn't working

Comments

@iamdefinitelyahuman
Copy link
Member

What was wrong?

Vyper 0.2.5 has added an optimization for reverting on nonpayable contracts: vyperlang/vyper#2172 This breaks the existing heuristic.

How can it be fixed?

Adjust the heuristic in project/compiler/vyper.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: nonpayable heuristic for vyper 0.2.5 eth-brownie/brownie
1 participant
@iamdefinitelyahuman