-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A version control could be used across the interface #116
Comments
Hm, indeed right now pyfirecrest doesn't really use this much. The only case where it is used, is for some incompatibility issue with the object storage link in external transfers. When an endpoint is new then in theory the client can easily catch the 404 result from the server, but when new arguments are added then they are silently ignored (as you mentioned in the recursive ls). |
I opened a PR on this, only because already had a look, and was half the way through... |
As far as I understand
self._api_version
is defined but not used.It would nice, if there was a check on functionalities that are not available in all version.
If the api version is outdated, return
NotImplementedError
or even better a custom "NotImplementedOnAPI
" for those methods.Example:
FirecREST
v1.15.0
for example, doesn't support recursivels
.in this case, if pyfirecrest is instantiated, with
self._api_version=1.15.0
it should returnNotImplementedOnAPI
whenlist_files(recursive =True)
(this issue is indirectly related to eth-cscs/firecrest#204)
The text was updated successfully, but these errors were encountered: