Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CAMP L2 #5608

Closed
wants to merge 8 commits into from
Closed

Conversation

hydrogenbond007
Copy link

pr to add camp network testnet to chainlist, here is the developer documentation

Copy link
Contributor

@macvts macvts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to sync forked repo to updated with reference from original branch

{
"name": "Camp Network Testnet V2",
"chain": "CampL2",
"icon": "CampL2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the submitted pr didn't have icon, so rather take this out or add up icon file

@hydrogenbond007
Copy link
Author

@macvts removed logo and updated the branch

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add parent field

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short name must be unique - but found CAMP more than once

@hydrogenbond007
Copy link
Author

@ligi Sorry kinda confused, here did you found the name twice?

@hydrogenbond007
Copy link
Author

Oh seems like you are referencing to #4878, that pr was for Camp Testnet V1 and has been depreciated, seems like #5331 was trying to accomplish the testnet v2 upgrade.

Copy link

This PR has no activity in a while - it will be closed soon.

@github-actions github-actions bot added the Stale label Oct 23, 2024
@github-actions github-actions bot closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants