Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent formating with title #758

Closed
kuzdogan opened this issue Jan 11, 2022 · 3 comments
Closed

Inconsistent formating with title #758

kuzdogan opened this issue Jan 11, 2022 · 3 comments

Comments

@kuzdogan
Copy link
Contributor

Looking at the JSON at https://chainid.network/chains.json I noticed the field title exists on 6 of the networks. In that case, title seem to have the complete name of the network but name only the short version. Whereas the name field in other networks contain the full name.

This causes inconsistent network names when using chainid.network to convert chainId's to chain names:
image

Networks with title

    "name": "Arbitrum Rinkeby",
    "title": "Arbitrum Testnet Rinkeby",

    "name": "Kintsugi",
    "title": "Kintsugi merge testnet",

    "name": "Rinkeby",
    "title": "Ethereum Testnet Rinkeby",

    "name": "Görli",
    "title": "Ethereum Testnet Görli",

    "name": "Kovan",
    "title": "Ethereum Testnet Kovan",

    "name": "Optimistic Kovan",
    "title": "Optimistic Ethereum Testnet Kovan",

Other networks' format

     // no title field
    "name": "Ethereum Testnet Ropsten",

    "name": "Ethereum Mainnet",

    "name": "Ubiq Network Testnet",
     ... 

It is possible to check if the title field exist as a workaround. Nevertheless the formatting seemed inconsistent and I was wondering if there was a specific reason behind this.

@ligi
Copy link
Member

ligi commented Jan 11, 2022

There is a ticket to backfill: #757

name was just too long for most networks - this is not really a name - this is a title. So introduced title and started to shorten the name for some networks - needs more work to backfil.

@ligi ligi closed this as completed Jan 11, 2022
@kuzdogan
Copy link
Contributor Author

Thanks. I guess the backfill ticket will be #723

@ligi
Copy link
Member

ligi commented Jan 11, 2022

yes - #723 - copy and paste error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants