Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(derive): Doc Touchups and Telemetry #105

Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix(derive): Doc Touchups and Telemetry #105

merged 2 commits into from
Apr 15, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 15, 2024

Description

Adds a bunch of missing telemetry, removing most inline TODO comments.

Also starts to add readme docs for kona-derive.

@refcell refcell added K-docs Kind: documentation A-derive Area: kona-derive crate labels Apr 15, 2024
@refcell refcell requested a review from clabby April 15, 2024 12:50
@refcell refcell self-assigned this Apr 15, 2024
clabby
clabby approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good. Couple nits on expanding the README, but can always do later :)

crates/derive/README.md Outdated Show resolved Hide resolved
crates/derive/README.md Show resolved Hide resolved
@refcell refcell added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 483059b Apr 15, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Apr 14, 2024
Closed
@clabby clabby deleted the refcell/metrice-comment branch April 19, 2024 18:51
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-docs Kind: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby