fix(derive): TryFrom<SpanBatch> for RawSpanBatch #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
refcell
changed the title
refcell
added
A-derive
Graphite App
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the
to_raw_span_batchmethod logic into theTryFromtrait implementation on theRawSpanBatch.Arguments to the
to_raw_span_batchmethod were unused anyways. The reference implementation accepts no arguments to itsToRawSpanBatchconversion method.Tests
Added unit tests around the trait implementation edge cases.