Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Inline Blob Validation #175

Merged
merged 1 commit into from
May 7, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented May 5, 2024

Description

Blob processing is specific to the functionality of the BlobProvider. This pr refactors the functional blob validation method into a type method and inline use.

@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate labels May 5, 2024
@refcell refcell added this to the Table Stakes milestone May 5, 2024
@refcell refcell requested a review from clabby May 5, 2024 01:00
@refcell refcell self-assigned this May 5, 2024
@refcell refcell changed the title fix(derive): inline blob verification into the blob provider fix(derive): Inline Blob Validation May 5, 2024
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@refcell refcell added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 016f452 May 7, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request May 7, 2024
This was referenced May 29, 2024
This was referenced Jun 6, 2024
This was referenced Jun 16, 2024
@clabby clabby deleted the refcell/blob-verification-simplification branch July 2, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants