-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployed bytecode comparison for preinstall create2deployer
#8984
Conversation
WalkthroughWalkthroughThe modifications in the codebase pertain to the update of comments and the alteration of function calls within the contract deployment mechanism. These changes are primarily due to a network hardfork, necessitating an update in the bytecode comparison logic that is integral to the deployment process of contracts. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
create2deployer
The deployed bytecode for
create2deployer
has been modified via the Canyon hardfork. This PR updates the bytecode comparison between ETH and OP mainnetsPreviously we were comparing the new implementation of
create2deployer
(0xF496...
deployed on ETH) against the existing implementation (0x13b0
deployed on OP/ETH), and were asserting that they were different. Now that canyon is active, the0x13b0
implementation on OP has been overwritten to match0xF496
For additional context: ethereum-optimism/op-geth#126