Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployed bytecode comparison for preinstall create2deployer #8984

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Jan 12, 2024

The deployed bytecode for create2deployer has been modified via the Canyon hardfork. This PR updates the bytecode comparison between ETH and OP mainnets

Previously we were comparing the new implementation of create2deployer (0xF496... deployed on ETH) against the existing implementation (0x13b0 deployed on OP/ETH), and were asserting that they were different. Now that canyon is active, the 0x13b0 implementation on OP has been overwritten to match 0xF496

For additional context: ethereum-optimism/op-geth#126

Copy link
Contributor

coderabbitai bot commented Jan 12, 2024

Walkthrough

Walkthrough

The modifications in the codebase pertain to the update of comments and the alteration of function calls within the contract deployment mechanism. These changes are primarily due to a network hardfork, necessitating an update in the bytecode comparison logic that is integral to the deployment process of contracts.

Changes

File Path Change Summary
.../bindgen/remote_handlers.go Updated comments and function calls for bytecode comparison due to hardfork adjustments in the contract deployment logic.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@spacesailor24
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@spacesailor24 spacesailor24 requested a review from tynes January 13, 2024 00:25
@spacesailor24 spacesailor24 changed the title Update deployed bytecode comparison Update deployed bytecode comparison for preinstall create2deployer Jan 16, 2024
@spacesailor24 spacesailor24 added this pull request to the merge queue Jan 16, 2024
Merged via the queue into develop with commit 077254e Jan 16, 2024
66 checks passed
@spacesailor24 spacesailor24 deleted the wyatt/preinstalls/create2-update branch January 16, 2024 20:18
dshiell pushed a commit to polymerdao/optimism-dev that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants