Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployed bytecode comparison for preinstall create2deployer #8984

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Update deployed bytecode comparison for preinstall create2deployer #8984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions op-bindings/bindgen/remote_handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ func (generator *BindGenGeneratorRemote) create2DeployerHandler(contractMetadata
return err
}

// We're expecting the bytecode for Create2Deployer to not match the deployment on OP,
// because we're predeploying a modified version of Create2Deployer that has not yet been
// deployed to OP.
// We're expecting the initialization bytecode for Create2Deployer to not match the init code on OP,
// because the deployment on OP has been overwritten by the Canyon hardfork, and the init code
// Etherscan returns for the OP deployment is from the initial outdated deployment.
// For context: https://github.com/ethereum-optimism/op-geth/pull/126
if err := generator.CompareInitBytecodeWithOp(contractMetadata, false); err != nil {
return fmt.Errorf("%s: %w", contractMetadata.Name, err)
}
if err := generator.CompareDeployedBytecodeWithOp(contractMetadata, false); err != nil {
if err := generator.CompareDeployedBytecodeWithOp(contractMetadata, true); err != nil {
return fmt.Errorf("%s: %w", contractMetadata.Name, err)
}

Expand Down
Loading