Skip to content

Commit

Permalink
Update EIP-5298: Move to Review (#6343)
Browse files Browse the repository at this point in the history
* Update eip-5298.md

* Update eip-5298.md

* Update eip-5298.md

* Update eip-5298.md

* Fix grammar

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
  • Loading branch information
2 people authored and pull[bot] committed Jan 31, 2024
1 parent 2b3d56f commit 3000000
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions EIPS/eip-5298.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: ENS Trust to hold NFTs under ENS name
description: An interface for a smart contract acting as a "trust" that holds tokens by ENS name.
author: Zainan Victor Zhou (@xinbenlv)
discussions-to: https://ethereum-magicians.org/t/erc-eip-5198-ens-as-token-holder/10374
status: Draft
status: Review
type: Standards Track
category: ERC
created: 2022-07-12
Expand All @@ -30,13 +30,17 @@ interface IERC_ENS_TRUST is ERC721Receiver, ERC1155Receiver {
}
```

3. `claimTo` MUST check if `msg.sender` is the owner of the ENS node (and/or approved by the domain in implementation-specific ways). The compliant contract then MUST make a call to the `safeTransferFrom` function of [EIP-721](./eip-712.md) or [EIP-1155](./eip-1155.md).
3. `claimTo` MUST check if `msg.sender` is the owner of the ENS node identified by `bytes32 ensNode` (and/or approved by the domain in implementation-specific ways). The compliant contract then MUST make a call to the `safeTransferFrom` function of [EIP-721](./eip-712.md) or [EIP-1155](./eip-1155.md).

4. Any `ensNode` is allowed.

## Rationale

1. ENS was chosen because it is a well-established scoped ownership namespace.
This is nonetheless compatible with other scoped ownership namespaces.

2. We didn't expose getters or setters for ensRoot because it is outside of the scope of this EIP.

## Backwards Compatibility

No backward compatibility issues were found.
Expand Down

0 comments on commit 3000000

Please sign in to comment.