From 300000074cf4aab74391d79a7c6d6b399478e74d Mon Sep 17 00:00:00 2001 From: xinbenlv Date: Fri, 20 Jan 2023 06:43:22 -0800 Subject: [PATCH] Update EIP-5298: Move to Review (#6343) * Update eip-5298.md * Update eip-5298.md * Update eip-5298.md * Update eip-5298.md * Fix grammar Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> --- EIPS/eip-5298.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/EIPS/eip-5298.md b/EIPS/eip-5298.md index 19a368e1aa05c1..5f885097c80ab4 100644 --- a/EIPS/eip-5298.md +++ b/EIPS/eip-5298.md @@ -4,7 +4,7 @@ title: ENS Trust to hold NFTs under ENS name description: An interface for a smart contract acting as a "trust" that holds tokens by ENS name. author: Zainan Victor Zhou (@xinbenlv) discussions-to: https://ethereum-magicians.org/t/erc-eip-5198-ens-as-token-holder/10374 -status: Draft +status: Review type: Standards Track category: ERC created: 2022-07-12 @@ -30,13 +30,17 @@ interface IERC_ENS_TRUST is ERC721Receiver, ERC1155Receiver { } ``` -3. `claimTo` MUST check if `msg.sender` is the owner of the ENS node (and/or approved by the domain in implementation-specific ways). The compliant contract then MUST make a call to the `safeTransferFrom` function of [EIP-721](./eip-712.md) or [EIP-1155](./eip-1155.md). +3. `claimTo` MUST check if `msg.sender` is the owner of the ENS node identified by `bytes32 ensNode` (and/or approved by the domain in implementation-specific ways). The compliant contract then MUST make a call to the `safeTransferFrom` function of [EIP-721](./eip-712.md) or [EIP-1155](./eip-1155.md). + +4. Any `ensNode` is allowed. ## Rationale 1. ENS was chosen because it is a well-established scoped ownership namespace. This is nonetheless compatible with other scoped ownership namespaces. +2. We didn't expose getters or setters for ensRoot because it is outside of the scope of this EIP. + ## Backwards Compatibility No backward compatibility issues were found.