Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ERC-20 contract into token, token registry, ICO and ICO registry #1127

Closed
rumkin opened this issue Jun 1, 2018 · 4 comments
Closed
Labels

Comments

@rumkin
Copy link

rumkin commented Jun 1, 2018

Title: ERC-1127
Status: Active
Type: ERC
Author: Rumkin <dev@rumk.in>
Created: 2018-05-01

I have several theses:

  1. ICO is one time action. When it ends there is no need to let it to stay into blockchain as active entry and it could be killed.
  2. ERC-20 interface itself have very predictable and strict behav and there is no need in special custom code to make it work. Any custom behavior should me moved out of that contract.
  3. There should be registry like ENS to register token names instead of hosting name in contract.
  4. There should be registry like ENS to register ICO contracts to make it easy to track new ICOs.
  5. Any tokens or digital asset could be owned by contract or address. But there is no standard like erc20 to describe ownerOf and ownedBy behavior.

Well I have no complete code. Just a several ideas which I want to discuss before writing something.

Workflow

As I already mentioned ICO is temporary contract which have short term lifetime. So It could be removed after ICO ends. As I think the workflow should looks like this:

  1. Subject (contract or address) publishes token contract which now belongs to that contract or.
  2. Subject publishes ICO contract.
  3. Subject transfer some token amount to ICO contract.
  4. Subject register ICO contract into ICO Registry.
  5. Someone buys tokens from ICO contract.
  6. ICO contract transfer tokens to that party.
  7. After ICO ends.
  8. ICO Registry mark ICO as completed and allow to register its token into token registry.
  9. Token is published into token registry.
@rumkin rumkin changed the title Split ERC-20.a into token, token registry, ICO and ICO registry Split ERC-20 contract into token, token registry, ICO and ICO registry Jun 1, 2018
@shrugs
Copy link

shrugs commented Jun 4, 2018

Most crowdsales are already abstracted from the token (see: OpenZeppelin). You can optionally extend the FinalizableCrowdsale with an option to destroy itself once it's been finalized.

Registering token names is probably not the job of a standard, and very much gets into the weeds of how that process is governed. see: #740

likewise for ICO registrars. There are a multitude of other, off-chain services which perform this task as well.

Tokens can be owned by an account, which may or may not be a contract. I'm not sure what you're asking, though; MyNFT.ownerOf(_address) works regardless of whether or not the address has code at that location or not.

@github-actions
Copy link

github-actions bot commented Dec 5, 2021

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Dec 5, 2021
@SUZWIL
Copy link

SUZWIL commented Dec 5, 2021

I have a erc20 token stuck.
I am the token holder but is stuck in smart contract.

@github-actions github-actions bot removed the stale label Dec 5, 2021
@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants