Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-684 is missing from the repository #2220

Closed
GregTheGreek opened this issue Jul 30, 2019 · 3 comments · Fixed by #6733
Closed

EIP-684 is missing from the repository #2220

GregTheGreek opened this issue Jul 30, 2019 · 3 comments · Fixed by #6733
Labels
stale

Comments

@GregTheGreek
Copy link
Contributor

GregTheGreek commented Jul 30, 2019 •
edited

I'm going to refer to this issue as EIP-684.

I've noticed that both Geth and Parity by default enable EIP-684, which is a consensus breaking change by default. EIP-684 was opened as an issue by Vitalik and promptly used as a patch 2 years ago, with no accompanying EIP.

Since this is in-fact a consensus breaking issue, we should have it documented as a valid EIP.
This was referenced Jul 30, 2019
Closed
Closed
@soc1c soc1c mentioned this issue Aug 27, 2019
Closed
@soc1c soc1c mentioned this issue Sep 13, 2019
Merged
@github-actions
Copy link

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Nov 20, 2021
@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this as completed Dec 4, 2021
@lightclient lightclient reopened this Mar 23, 2023
@Pandapip1 Pandapip1 changed the title [Missing] EIP-684 EIP-684 is not an EIP Mar 24, 2023
@Pandapip1 Pandapip1 changed the title EIP-684 is not an EIP EIP-684 is missing from the repository Mar 24, 2023
@RenanSouza2
Copy link
Contributor

PR documenting this missing EIP #6784

@Pandapip1 Pandapip1 linked a pull request Mar 27, 2023 that will close this issue
Add EIP: Revert creation in case of collision #6733
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
3 participants
@lightclient @GregTheGreek @RenanSouza2