-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional relates-to
preamble key
#5274
Comments
Would you mind if I draft a PR? It's usually the way that these changes get made the quickest. |
The way I currently interpret I'm not against renaming the field, but I am weakly against (open to discussion) adding a separate second field. I suspect a lot of people read the |
To quickly summarize past discussion on this topic, there are two different viewpoints on what the problem actually is: (1) (2) |
I think that's a good summary. Shall we take it to the EIPIP meeting for an easier discussion? |
(3) People shouldn't be linking to other EIPs that are not critical to understanding the EIP in question, and if an EIP is critical to understanding the EIP in question then it is "required reading". |
I wonder how many reader and authors refer to 'requires' field when they mean 'require reading'... |
Somewhat relevant to this discussion: in ethereum/eipw@d8a40d1, I added a lint that checks links in the body to make sure their status is at least as advanced as the EIP being linted. I believe that satisfies @MicahZoltu's immutability concern, regardless of what ends up in the |
Yes, it does if we make EIPW required. 😀 That being said, I still think there is value in putting all referenced EIPs in the Many authors have a bunch of material in their motivation/rationale that basically reduces to "I don't like the 15 other standards, so I am writing a 16th standard that is better". Ideally, authors would write a useful standard in isolation and leave that sort of text for a blog post, autobiography, or made-for-TV movie about the life of the author. |
One thing I'll add about this is that the main reason to not have external links in the EIPs is because we want to make the EIP editor role as easy as possible and not require judgement about every link in an EIP. IMO this proposal adds this level of overhead to editor's role, and adds way less value than allowing (high quality) external links (e.g. only links to the EL/CL specs). If we do have an "EIP editor judgement/complexity" budget, I'd much rather we spend it on a good policy around external links. Just my 2 gwei :-) |
@timbeiko Is your thinking that if we had Unrelated: I like calling it an "EIP Editor Judgement Budge". |
Yes, and "relates-to" is pretty vague, so do we just accept anything by default? If so, are there "abuse" vectors, e.g. saying your EIP |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Still relevant |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
relates-to:
as an optional fieldrelates-to
as an optional preamble key
relates-to
as an optional preamble keyrelates-to
optional preamble key
relates-to
optional preamble keyrelates-to
preamble key
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback. |
It seems @Pandapip1 has been suggesting using
requires:
to add EIP that is related. but I think there is a strong need to differentiate "requires" vs "related to" for example, in some of the EIP, they are related and often implementations complied with bot at the same time, but they are decoupled and meant to allow to be implement without one-another, such as #1202 vs #5267.Hence, I propose to add relates-to as an optional field
The text was updated successfully, but these errors were encountered: