Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP editors should explain that ERC was renamed to EIP #5424

Closed
2 tasks
fulldecent opened this issue Aug 7, 2022 · 10 comments · Fixed by #5273
Closed
2 tasks

EIP editors should explain that ERC was renamed to EIP #5424

fulldecent opened this issue Aug 7, 2022 · 10 comments · Fixed by #5273
Labels
question r-process Relates to an EIP Process w-stale Waiting on activity

Comments

@fulldecent
Copy link
Contributor

Pull Request

No response

What happened?

The EIP editors have apparently decided that ERCs shall be renamed to EIPs. (I can see this in the CI bots' notices.)

That's fine and I respect your control of this naming.

Before I go around telling everybody that ERC-721 is now renamed to EIP-721, it will be helpful if the EIP official documentation does not contradict me. Please do these:

Relevant log output

No response

@Pandapip1
Copy link
Member

Update https://github.com/ethereum/EIPs/blob/master/README.md to use this new wording

The official documentation about the EIP process is in EIP-1. Here is the reference you are looking for: https://eips.ethereum.org/EIPS/eip-1#eip-numbers

Make a blog post documenting this significant change and link to it prominently from the README and EIP-1

The EIP editors don't have a blog. I know @MicahZoltu does, but he's no longer an editor. I guess I could submit a PR to the ethereum.org website repo.

@Pandapip1
Copy link
Member

I would also hold off on telling people that it's EIP-721, as the naming is still a contentious issue: #5273

@xinbenlv
Copy link
Contributor

@fulldecent the EIP Editor group has been discussing it yesterday EIPIP Meeting. It seems the raw unfinalized consensus in the EIP Editors are it will be flexible between ERC and EIP.

@fulldecent
Copy link
Contributor Author

lol this is weak guidance from a group that is setting rules for people that make rules and guidance

@Pandapip1
Copy link
Member

Pandapip1 commented Aug 12, 2022

this is weak guidance

We aren't here to guide anything that is outside the scope of the EIPs and related repositories. As discussed in the EIPIP 62 meeting, we don't care if you call the standard with number 20 EIP-20, ERC-20, or BANANA-20. For the purposes of EIPs, the standard must be referenced with the hyphenated form EIP-20, but the consensus is currently split on that anyways.

@fulldecent
Copy link
Contributor Author

Got it, thank you

@Pandapip1 Pandapip1 added the bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug. label Aug 23, 2022
@Pandapip1 Pandapip1 changed the title [Bug]: Explain in text that ERC was renamed to EIP Explain in text that ERC was renamed to EIP Aug 23, 2022
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Aug 31, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Sep 8, 2022
@Pandapip1 Pandapip1 added question r-process Relates to an EIP Process and removed bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug. labels Sep 10, 2022
@Pandapip1 Pandapip1 changed the title Explain in text that ERC was renamed to EIP EIP editors should explain that ERC was renamed to EIP Sep 10, 2022
@Pandapip1 Pandapip1 linked a pull request Sep 10, 2022 that will close this issue
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 21, 2022
@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question r-process Relates to an EIP Process w-stale Waiting on activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants