Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eth_signTransaction to the RPC API #728

Closed
wighawag opened this issue Oct 4, 2017 · 6 comments
Closed

add eth_signTransaction to the RPC API #728

wighawag opened this issue Oct 4, 2017 · 6 comments
Labels

Comments

@wighawag
Copy link
Contributor

wighawag commented Oct 4, 2017

as mentioned here : #636
eth_sendTransaction is doing 2 things: signing and sending

since we already have eth_sendRawTransaction we would just need the extra method : eth_signTransaction

eth_sendTransaction would then be used as a convenient option only.

Rationale:

eth_signTransaction is useful in situations where you want to control when the transaction is broadcasted to the network. Currently there is no way to get a signed transaction out of the user without sending to the network at the same time.

@frozeman
Copy link
Contributor

frozeman commented Oct 9, 2017

@bas-vk don't we have that already?

@onbjerg
Copy link
Contributor

onbjerg commented Oct 10, 2017

Doesn't seem to be documented at least. eth_sign adds a prefix to the message being signed, so wouldn't work for transactions.

@ghost
Copy link

ghost commented Oct 19, 2017

Totally behind this. I think there needs to be a more robust RPC interface in general. This one in particular would be super useful for dapps that want to use Raiden-like capabilities in their code.

@leonardinius
Copy link

leonardinius commented Nov 23, 2017

Just to drop the note, we also would like to see that as part of public (read documented) JSON-RPC APIs, also to simplify and prevent double spend issues.

Do you happen to have some ETAs or some other indications when (and if likely at all) we will see that happen?

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Jan 2, 2022
@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants