-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brain wallet discussion #76
Comments
We wrote at the same time! #75 |
The attributes I would be interested in personally:
|
We have a standard library that will convert hex addresses to ICAP addresses. I don't see the advantage of needing an address starting with 0 |
To have addresses supported as ICAP Direct, the private key needs to fit into 155 bits. |
I see. What's the advantage of doing so? A bank would still need to implement ethereum, it's not as if magically we can receive direct transfers just because our address fits into theirs.. |
Of course, using email as a username is just a suggestion, it doesn't need to enforce the rule |
I haven't chosen a side yet which address format to prefer (checksummed, ICAP or something else), but as ICAP might get a bit of following, it probably makes sense to design the brain wallet in conformance. |
Shall we close this one in favor of #75 ? |
There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
I think it would be important and useful to discuss brain wallets and eventually settle on a method, which can be cross-application.
Current implementations
I am aware of three brain wallet implementations:
Run
sha3
on the seed 16384 times. Then runsha3
until the first byte of the address is 0 (to be compatible with ICAP Direct).A simple
sha3
over the passphrase.Requires a passphrase and a userid, both at least 10 characters long. Use the concatenated userid and passphrase as the input to
PBKDF2
with 2000 rounds, 32 bytes key size andsha256
hashing.(Note: the brain wallet part in Quorum is not supposed to have more Ether than what is needed to execute the contracts and therefore it wasn't made to be very complex)
Passphrase generation
@alexvandesande has posted a nice little tool to generate memorable passphrases. There are many other dictionary tools.
A common interface
It would be important to define a common key derivation method with the inputs required. These inputs also should have minimum length/strength requirements.
Hopefully this can be a start to a discussion to devise such a standard.
cc @alexvandesande @ryancdotorg @romanman @Gustav-Simonsson
Update: it seems like we were writing at the same time with @alexvandesande. #75 proposes a specific method.
The text was updated successfully, but these errors were encountered: