-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new two-week review process to EIPs #1100
Changes from all commits
5a4a19c
34e19bf
c84ee64
d6bed1b
d96b7bf
0b4245e
d09dd90
58d22b4
9c0b7b5
06eacee
d0735df
bb45b6a
50ae6ac
ccfaf32
dfeede3
204b3ec
321d8fe
f6a321c
449f07f
75c8edc
0ebde39
46e54b2
03aab50
efa96f2
779c13a
68e235d
fa34504
cef7d9d
289c9a3
98cb10d
dc32352
3dd4b31
4969df9
b471095
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
- Last Call | ||
- Draft | ||
- Accepted | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is "Approved" and "Accepted" the same thing? (Core EIPs only) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please see cef7d9d The word "accepted" had previously been (the current EIP) used many times with different meaning in the text so as to make the word ambiguous. This is why I renamed accepted to approved. I'm NOW undoing that change because it is not necessary. So I have reworded everything to preserve "Accepted" as the state name. Other uses of the word are now "agreeable", "supported" etc. to avoid using "accept" for other meanings. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, W and T are next to each other on the keyboard :-p |
||
- Final | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to:
Testing that locally, it doesn't render the newline since they are stripped, but it does show the colon. We could fix up the rendering of the link and newline later after this is merged. Although I noticed that you managed to get the newline to render, so if you know how to fix that, please do so.