Replaced sha3 with keccak256 in EIP-712 assets #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjmelements
approved these changes
Nov 18, 2018
|
@LogvinovLeon can you approve/decline? This seems to be related to EIP-712. |
LogvinovLeon
approved these changes
Jan 14, 2019
|
@axic Approved |
PaulRBerg
added a commit
to AztecProtocol/aztec-v1
that referenced
this pull request
Apr 30, 2019
PaulRBerg
added a commit
to AztecProtocol/aztec-v1
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the latest commits on
ethereumjs-util,sha3has been renamed tokeccak256to avoid confusion.