-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1193: Remove web3 compatibility section #2127
Conversation
This EIP had a section describing how to be compatible with a certain beta version of web3 1.0.0. This would look fairly arbitrary to the uninformed reader. Also, it would be even weirder in the near future, as some changes to web3's versioning will be announced soon. This PR removes that section, making the EIP independent from any particular library consuming it.
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
Can any of the original authors do a review of this change? @frozeman maybe? Thanks! |
This section is important for those who are trying to create a js provider that would work with older dapps. Without providing |
The current situation with web3.js is complicated. I'm pretty sure we are going to support this EIP in |
What is the status of this? |
The versioning change in web3.js has already happened, so this comment is now outdated. This EIP was supported in web3.js from beta.38 to beta.55 but it's not supported anymore. MetaMask will stop supporting its older interface in Jan 13th 2020, so Web3.js |
Outdated - this spec has been improved in this regard |
can be closed @alcuadrado |
This EIP had a section describing how to be compatible with a certain beta version of web3 1.0.0. This would look fairly arbitrary to the uninformed reader. Also, it would be even weirder in the near future, as some changes to web3's versioning will be announced soon.
This PR removes that section, making the EIP independent from any particular library consuming it.