Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1193: Remove web3 compatibility section #2127

Closed
wants to merge 1 commit into from

Conversation

alcuadrado
Copy link
Member

This EIP had a section describing how to be compatible with a certain beta version of web3 1.0.0. This would look fairly arbitrary to the uninformed reader. Also, it would be even weirder in the near future, as some changes to web3's versioning will be announced soon.

This PR removes that section, making the EIP independent from any particular library consuming it.

This EIP had a section describing how to be compatible with a certain beta version of web3 1.0.0. This would look fairly arbitrary to the uninformed reader. Also, it would be even weirder in the near future, as some changes to web3's versioning will be announced soon.

This PR removes that section, making the EIP independent from any particular library consuming it.
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

@alcuadrado
Copy link
Member Author

Can any of the original authors do a review of this change? @frozeman maybe? Thanks!

@ryanio
Copy link
Contributor

ryanio commented Jul 3, 2019

This section is important for those who are trying to create a js provider that would work with older dapps. Without providing sendAsync in the provider interface, the provider wouldn't work with any previously created dapps that rely on web3.js prior to 1.0.0-beta38.

@alcuadrado
Copy link
Member Author

The current situation with web3.js is complicated. v1.0.0-beta.37 will be published as v1.0.0. v1.0.0-beta.38+ will be known as v2.x, which won't be published for some time. This comment will eventually bring even more confusion.

I'm pretty sure we are going to support this EIP in v1.x. Will get back with a confirmation.

@axic
Copy link
Member

axic commented Nov 23, 2019

What is the status of this?

@alcuadrado
Copy link
Member Author

The versioning change in web3.js has already happened, so this comment is now outdated. This EIP was supported in web3.js from beta.38 to beta.55 but it's not supported anymore.

MetaMask will stop supporting its older interface in Jan 13th 2020, so Web3.js 1.x will have to support this EIP. In the meantime I would just remove this section. //cc @cgewecke

@pedrouid
Copy link
Contributor

Outdated - this spec has been improved in this regard

@pedrouid
Copy link
Contributor

can be closed @alcuadrado

@alcuadrado alcuadrado closed this Apr 27, 2020
@alcuadrado alcuadrado deleted the patch-1 branch April 27, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants