Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-2181: Increase Clique's DIFF_INTURN #2181

Closed
wants to merge 2 commits into from
Closed

Conversation

soc1c
Copy link
Contributor

@soc1c soc1c commented Jul 9, 2019

This document proposes a patch for the Clique proof-of-authority consensus engine that could be used by Ethereum testing and development networks in the future which improves performance and stability.

resolves goerli#13

partially replaces #1955

thanks to @tkstanczak for helping out with this

@karalabe
Copy link
Member

At the specified BLOCK_NUMBER, change the block score (difficulty) calculation for blocks signed in turn DIFF_INTURN to 7. The block score for out-of-turn signers remains at 1 since it just needs to be an arbitrary baseline constant.

The original difficulty numbers were not arbitrary at all. They were chosen so that online in-turn signers cannot be censored out, and also that an "offline" in-turn signer cannot pop in after the fact and try to censor out already published blocks. The original design was that anyone online can influence the chain, and anyone offline cannot.

Re the EIP however, I guess by raising the difficulty to 7, you are raising the number of consecutive blocks that need to be all out of turn (and concurrent on 2 chains) for the network to get stuck. So I think the network would need at least 15 online signers + 7 offline to pull off a possibility of getting stuck (even then, you'd need a network partition too for it).

Isn't this EIP however covering the same solution as the one that reduces the number of required signers though? I.e. if I remove the need for a majority of signers to be present, is this EIP still needed?

@github-actions
Copy link

github-actions bot commented Sep 8, 2020

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Sep 8, 2020
@github-actions
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Clique DIFF_INTURN
4 participants