Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discussion URL metadata to EIP-721 #2434

Merged
merged 2 commits into from
Dec 15, 2019
Merged

Conversation

fulldecent
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@fulldecent fulldecent mentioned this pull request Dec 11, 2019
14 tasks
EIPS/eip-721.md Outdated
@@ -2,6 +2,7 @@
eip: 721
title: ERC-721 Non-Fungible Token Standard
author: William Entriken <github.com@phor.net>, Dieter Shirley <dete@axiomzen.co>, Jacob Evans <jacob@dekz.net>, Nastassia Sachs <nastassia.sachs@protonmail.com>
discussions-to: https://github.com/ethereum/EIPs/pull/841
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EIP-1 states the URL can't be a PR.

@fulldecent
Copy link
Contributor Author

Thank you. Updated to the issue URL.

@axic axic changed the title Add new discussion URL metadata Add discussion URL metadata to EIP-721 Dec 15, 2019
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only adds the long existing discussion URL to the finalized EIP-721.

@axic axic merged commit 8344ca6 into ethereum:master Dec 15, 2019
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants