Add EIP: Private Equity #7331
Add EIP: Private Equity #7331
Conversation
github-actions
bot
added
c-new
File
|
eth-bot
changed the title
eth-bot
added
a-review
github-actions
bot
added
w-ci
|
The commit 49c9fae (as a parent of 8928d25) contains errors. |
EIPS/eip-7331.md
Outdated
|
|
||
| ## Reference Implementation | ||
|
|
||
| [ERC-20](./eip-20.md) |
There was a problem hiding this comment.
why ERC-20 or ERC-3643 is a reference implementation?
There was a problem hiding this comment.
Hi Xin,
The Fund.sol smart contract functionality consists of interacting with ERC-3643 and ERC-20 standard token smart contracts. But in essence, it can interact with any token smart contracts that implements the ERC-20 interface. Do you recommend removing the reference implementations?
There was a problem hiding this comment.
I mean: the section of "Reference Implementation" is meant for you as author to provide implementations of the standard interface you proposal, in another word, we expect to see a working piece of smart contract code that comply with your proposed ERC
There was a problem hiding this comment.
Hi Xin,
Added the Fund.sol implementation to the section.
|
|
||
| ## Abstract | ||
|
|
||
| A private equity fund is a type of investment fund that pools together capital from high-net-worth individuals, institutional investors, and sometimes, pension funds to make investments in private companies. These funds are managed by private equity firms, which specialize in acquiring ownership stakes in companies and actively managing them to generate returns. |
There was a problem hiding this comment.
This doesn't really explain what this ERC does.
There was a problem hiding this comment.
I would say more along the lines of "this standard proposes a standardized interface for Private Equity smart contracts" or something
| } | ||
| ``` | ||
|
|
||
| ## Rationale |
There was a problem hiding this comment.
Hey @lightclient , Updated eip-7331.md with the Rationale.
|
Agree with @lightclient that the current design just isn't generic enough to make sense as an ERC. |
added rationale
|
Thanks for adding Rationale section, definitely helps. |
@mattstam @lightclient, thank you for your comments. Our intention is to provide a modular interface to complement an institution's security token needs for private equity. As this standard matures, it can be used by any institution to offer regulated investment options without major upgrades to the smart contracts. |
EIPS/eip-7331.md
Outdated
| ## Specification | ||
|
|
||
| ```solidity | ||
| // SPDX-License-Identifier: GPL-3.0 |
EIPS/eip-7331.md
Outdated
| ## Reference Implementation | ||
|
|
||
| ```solidity | ||
| // SPDX-License-Identifier: GPL-3.0 |
| @@ -0,0 +1,64 @@ | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
assets/eip-7331/contracts/Fund.sol
Outdated
| @@ -0,0 +1,159 @@ | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
assets/eip-7331/contracts/IFund.sol
Outdated
| @@ -0,0 +1,190 @@ | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
There was a problem hiding this comment.
Hello Pandapip1,
Thanks, and addressed.
|
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: