Add ERC: Interest Rate Swaps #178
Conversation
eip-review-bot
changed the title
|
@axic, @g11tech, @Pandapip1, @SamWilsn, @xinbenlv @abcoathup Could someone tell what should be the EIP number for this new proposal ? I know that it's no longer the PR number. |
|
eip-review-bot
changed the title
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
eip-review-bot
changed the title
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
|
@axic, @g11tech, @Pandapip1, @SamWilsn, @xinbenlv @abcoathup, @eip-review-bot I resolved all the issues that were discussed on Monday, but the PR is still not merged, requiring the Should I send a request for the next EIP Editing Office, or the pull request will be merged automatically ? |
|
The commit a13fe80 (as a parent of 2ce2968) contains errors. |
| --- | ||
| eip: 7586 | ||
| title: Interest Rate Swaps | ||
| description: Interest rate swaps derivative contracts |
There was a problem hiding this comment.
| description: Interest rate swaps derivative contracts | |
| description: On-chain implementation of derivative contracts swapping fixed and floating interest rates. |
Feel free to continue improving this, but your description needs to be more descriptive than just your title.
|
|
||
| /** | ||
| * @notice Returns the notional amount in unit of asset to be transferred when swapping IRS. This amount serves as the basis for calculating the interest payments, and may not be exchanged | ||
| * Example: If the two parties aggreed to swap interest rates in USDC, then the notional amount may be equal to 1,000,000 USDC |
There was a problem hiding this comment.
I think removing "USDC" here would make it more clear.
| /** | ||
| * @notice Returns the interest payment frequency | ||
| */ | ||
| function paymentFrequency() external view returns(uint256); |
There was a problem hiding this comment.
This is in seconds? Might be good to note that in the comment.
| * @notice Returns an array of specific dates on which the interest payments are exchanged. Each date MUST be a Unix timestamp like the one returned by block.timestamp | ||
| * The length of the array returned by this function MUST equal the total number of swaps that should be realized | ||
| * | ||
| * OPTIONAL |
There was a problem hiding this comment.
What does "OPTIONAL" mean here: that the contract doesn't need to implement this function, or that this function may revert? Should make that clear in the comment.
There was a problem hiding this comment.
We prefer SVG graphics if you can, or failing that, please provide a PNG.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: