Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Support eth_chainId #4810

Closed
axic opened this issue Jan 26, 2018 · 1 comment
Closed

Support eth_chainId #4810

axic opened this issue Jan 26, 2018 · 1 comment

Comments

@axic
Copy link
Member

axic commented Jan 26, 2018

See ethereum/EIPs#695 and openethereum/parity-ethereum#6329 (merged into parity).

This would be useful for the upcoming ewasm testnet & tooling around it.

@halfalicious
Copy link
Contributor

halfalicious commented Apr 23, 2018

I'd like to take this one 😀 A couple of quick questions:

  • Is there any documentation for regenerating libweb3jsonrpc\Ethface.h after I've added the new chainId function to eth.json? I've tried running jsonrpcstub eth.json --cpp-server=dev::rpc::EthFace but there are some differences between my generated file and the existing one (e.g. my EthFace class extends jsonrpc::AbstractServer<EthFace> rather than ServerInterface<EthFace>). Apologies if this is a naive question, I haven't used jsonrpcstub before.
  • Same goes for tests\unittests\libweb3jsonrpc\WebThreeStubClient.h - is there any documentation for how to properly regenerate this? Additionally, which json file do I need to update? I don't see one in tests\unittests\libweb3jsonrpc

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants