Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Aleth never clears transaction queue's "dropped transactions" list #5688

Closed
halfalicious opened this issue Jul 22, 2019 · 3 comments · Fixed by #5687
Closed

Aleth never clears transaction queue's "dropped transactions" list #5688

halfalicious opened this issue Jul 22, 2019 · 3 comments · Fixed by #5687

Comments

@halfalicious
Copy link
Contributor

Transactions which are dropped during transaction queue import are stored in TransactionQueue::m_dropped. A max size isn't enforced on m_dropped and m_dropped is only cleared when the entire Transaction Queue is cleared (TransactionQueue::clear), which doesn't happen during normal execution.

@chfast
Copy link
Member

chfast commented Jul 22, 2019

Why do we keep them?

@gumb0
Copy link
Member

gumb0 commented Jul 22, 2019

@chfast I think to immediately drop them withoud validation, if they come once again over the network

@chfast
Copy link
Member

chfast commented Jul 22, 2019

Some kind of ring buffer would be nicer here, don't you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants