Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

EIP 684: contract creation on nonempty code or nonzero nonce fails. #4384

Merged
merged 2 commits into from
Aug 24, 2017

Conversation

pirapira
Copy link
Member

@pirapira pirapira commented Aug 23, 2017

Note this change is applied for all blocks from block number zero.

@winsvega
Copy link
Contributor

So once and for all. address collision result in OOG, on all forks including future updates.

For transactions that will run parallel FCFS rules are applied

@pirapira
Copy link
Member Author

FCFS?

@winsvega
Copy link
Contributor

FirstComeFirstServed

@pirapira
Copy link
Member Author

I see. Well, transactions have nonces.

@winsvega
Copy link
Contributor

there was an EIP about different transaction proccessing

@pirapira
Copy link
Member Author

Rebased.

@codecov-io
Copy link

codecov-io commented Aug 24, 2017

Codecov Report

Merging #4384 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4384      +/-   ##
===========================================
- Coverage    67.75%   67.73%   -0.02%     
===========================================
  Files          303      303              
  Lines        23207    23205       -2     
===========================================
- Hits         15723    15718       -5     
- Misses        7484     7487       +3
Impacted Files Coverage Δ
libethereum/Executive.cpp 59.84% <100%> (-0.31%) ⬇️
libethereum/Account.h 90.9% <0%> (-4.55%) ⬇️
libethereum/State.cpp 76.6% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a73ed0...91832e8. Read the comment docs.

Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge branch at the test repo at the same time

@pirapira pirapira merged commit 9bd9318 into develop Aug 24, 2017
@pirapira pirapira deleted the address-collision-fails branch August 24, 2017 12:45
@cdetrio
Copy link
Member

cdetrio commented Sep 29, 2017

EIP 684: ethereum/EIPs#684

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants