-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lints to ensure link text for EIPs should match the EIP's number #67
Comments
Note: if it links to a section, then this lint should be ignored, such as |
That's a good point! |
Hi, I would like take this up with Katya |
Hi @SamWilsn, yep, we both would like to contribute into it. Please, assign us to this issue |
Hi @SamWilsn, taking into account @Pandapip1 's comment about sections, should all these links matching the pattern
|
This paragraph covers those examples:
So:
However, |
@SamWilsn could you please explain why |
Because it doesn't have a subsection (after the |
if |
Pretty much. So URLs with a |
@SamWilsn, for |
|
Let's create two lints:
markdown-link-eip
If the link destination matches the pattern
eip-([^.]*)\.md$
, trigger if the link text does not match^(EIP|ERC)-\1$
, where\1
is the proposal's number from the file name (aka capture group 1.)For example:
[EIP-1](./eip-2.md)
[EIP-1: Foo](./eip-1.md)
[Another Proposal](./eip-1.md)
If the link destination matches the pattern
eip-([^.]*)\.md#.+$
, trigger if the link text does not match^(EIP|ERC)-\1\s*\S+
, where\1
is the proposal's number from the file name (aka capture group 1.) Note that this pattern allows trailing characters.For example:
[EIP-1](./eip-1.md#motivation)
[EIP-2: Hello](./eip-1.md#abstract)
[Another Proposal](./eip-1.md#rationale)
markdown-link-other
If the link text begins with EIP or ERC, the link target must be an EIP. For example:
[EIP-2](../assets/eip-2/foo.txt)
The text was updated successfully, but these errors were encountered: