Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent mode is c-mode in define-derived-mode #49

Closed
tsuu32 opened this issue Dec 4, 2019 · 2 comments
Closed

parent mode is c-mode in define-derived-mode #49

tsuu32 opened this issue Dec 4, 2019 · 2 comments

Comments

@tsuu32
Copy link
Contributor

tsuu32 commented Dec 4, 2019

I think this is problematic.

I use

(add-hook 'c-mode-hook #'irony-mode)

in init file, so solidity-mode enable irony-mode (undesirable).

Solidity-mode should be

(define-derived-mode solidity-mode prog-mode "solidity"

?

@LefterisJP
Copy link
Collaborator

Hello @tsuu32!

Thank you for trying out emacs-solidity.

When I first made this language mode it was suggested from various guides to derive from c-mode for languages like Solidity which are similar to C in syntax. Example guide seen here.

We can try prog-mode to solve your problem but it may need some more work than just switching c-mode with prog-mode as there may be some characteristics of c-mode that will need to be reconfigured.

I can try it when I find some time, or if you also have time Pull Requests are more than welcome!

@LefterisJP
Copy link
Collaborator

Fixed by #50. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants