Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pysha3 as an option #44

Closed
carver opened this issue Nov 2, 2022 · 5 comments
Closed

Remove pysha3 as an option #44

carver opened this issue Nov 2, 2022 · 5 comments

Comments

@carver
Copy link
Collaborator

carver commented Nov 2, 2022

pysha3 is no longer maintained: tiran/pysha3#17 (comment)

Remove it as an option. Use hashlib as the default option if neither pycryptodome nor pysha3 are installed

Requires a major version bump. Maybe it's time to go to v1?

@kclowes
Copy link
Contributor

kclowes commented Nov 2, 2022

Unfortunately, hashlib doesn't have keccak implemented at this point.

@kclowes
Copy link
Contributor

kclowes commented Nov 2, 2022

So we may just have to have pycryptodome be the backend? Do you see any other options @carver?

@carver
Copy link
Collaborator Author

carver commented Nov 2, 2022

So we may just have to have pycryptodome be the backend? Do you see any other options @carver?

Oof, not really, besides importing the source of pysha3 and taking over maintenance, which is probably not realistic :/

@Uxio0
Copy link
Contributor

Uxio0 commented Nov 3, 2022

You can use: https://pypi.org/project/safe-pysha3/ . I updated the breaking C code, so now it's not compatible with Python < 3.9 , but we can use previous pysha3 version for that

@kclowes
Copy link
Contributor

kclowes commented Nov 9, 2022

Closed via #45. Thanks @Uxio0!

@kclowes kclowes closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants