Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC-223 to token standards. #9651

Merged
merged 18 commits into from
Jul 3, 2023
Merged

Add ERC-223 to token standards. #9651

merged 18 commits into from
Jul 3, 2023

Conversation

Dexaran
Copy link
Contributor

@Dexaran Dexaran commented Mar 7, 2023

Add ERC-223 token standard to the standards list.

Original ERC-223 proposal: ethereum/EIPs#223

Description

EIP-223 is now officially submitted, so I would highlight the importance of adding this token standard to the standards list.

It is worth noting that several standards (including those presented in the list) were developed on the basis of the ERC-223, including ERC-777, ERC-677: TransferAndCall standard.

The transferring logic of ERC-721 is completely based on ERC-223.

The addition of this standard will fill in the missing link between the ERC20 standard and standards that already use the ERC223 patterns as well as help properly understanding the interaction patterns for Ether-like tokens.

@wackerow
Copy link
Member

wackerow commented Mar 7, 2023

Hey @Dexaran, thanks for dropping this PR! 🙏... could you do us a favor and close either this one or #9646, depending which one you want reviewed? Note you can always push additional changes to a PR branch that you've opened to prevent having to open a new one if there are any issues.

@Dexaran
Copy link
Contributor Author

Dexaran commented Mar 7, 2023

Hey @Dexaran, thanks for dropping this PR! 🙏... could you do us a favor and close either this one or #9646, depending which one you want reviewed? Note you can always push additional changes to a PR branch that you've opened to prevent having to open a new one if there are any issues.

Closed #9646

For some reason gatsby timed out again even with this PR. I'm not sure what caused this.

@Dexaran
Copy link
Contributor Author

Dexaran commented Mar 9, 2023

@Dexaran
Copy link
Contributor Author

Dexaran commented Mar 21, 2023

Hello

Should I reopen the PR? Or is something needs to be changed?

I repeat that gatsby just timed out without giving any errors so I don't know what was wrong.

@Dexaran Dexaran requested a review from nhsz as a code owner March 28, 2023 19:06
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 28, 2023

✅ ethereum-org-website-dev deploy preview ready

@Dexaran
Copy link
Contributor Author

Dexaran commented Apr 27, 2023

Hello,

It is one month since I opened a Pull Request. I've fixed inconsistencies and the PR passed gatsby tests.

Can I get any details about what is the status of this?

@nhsz
Copy link
Member

nhsz commented May 2, 2023

Hello,

It is one month since I opened a Pull Request. I've fixed inconsistencies and the PR passed gatsby tests.

Can I get any details about what is the status of this?

cc @wackerow

@Dexaran
Copy link
Contributor Author

Dexaran commented May 16, 2023

cc @nhsz @wackerow @samajammin @corwintines @pettinarip @jmcook1186 @minimalsm

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just left semantic and grammatical suggestions, then I think this is good to go! Thanks @Dexaran!

src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
Dexaran and others added 8 commits May 17, 2023 08:16
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Dexaran and others added 6 commits May 21, 2023 17:54
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@Dexaran Dexaran requested a review from wackerow May 21, 2023 14:13
@Dexaran
Copy link
Contributor Author

Dexaran commented May 21, 2023

@wackerow The requested changes are implemented.

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@Dexaran Dexaran requested a review from wackerow May 22, 2023 19:07
@Dexaran
Copy link
Contributor Author

Dexaran commented May 26, 2023

@wackerow can we move further with this?

@corwintines corwintines merged commit c635332 into ethereum:dev Jul 3, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jul 3, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2023 Ethereum.org Contributor:

GitPOAP: 2023 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants