-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC-223 to token standards. #9651
Conversation
Closed #9646 For some reason gatsby timed out again even with this PR. I'm not sure what caused this. |
Hello, any update? @wackerow @samajammin @corwintines @pettinarip @minimalsm @jmcook1186 |
Hello Should I reopen the PR? Or is something needs to be changed? I repeat that gatsby just timed out without giving any errors so I don't know what was wrong. |
✅ ethereum-org-website-dev deploy preview ready
|
Hello, It is one month since I opened a Pull Request. I've fixed inconsistencies and the PR passed gatsby tests. Can I get any details about what is the status of this? |
cc @wackerow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Just left semantic and grammatical suggestions, then I think this is good to go! Thanks @Dexaran!
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@wackerow The requested changes are implemented. |
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@wackerow can we move further with this? |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Add ERC-223 token standard to the standards list.
Original ERC-223 proposal: ethereum/EIPs#223
Description
EIP-223 is now officially submitted, so I would highlight the importance of adding this token standard to the standards list.
It is worth noting that several standards (including those presented in the list) were developed on the basis of the ERC-223, including ERC-777, ERC-677: TransferAndCall standard.
The transferring logic of ERC-721 is completely based on ERC-223.
The addition of this standard will fill in the missing link between the ERC20 standard and standards that already use the ERC223 patterns as well as help properly understanding the interaction patterns for Ether-like tokens.