Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine_executePayload QoS when sync triggered #91

Closed
djrtwo opened this issue Oct 29, 2021 · 1 comment
Closed

engine_executePayload QoS when sync triggered #91

djrtwo opened this issue Oct 29, 2021 · 1 comment

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Oct 29, 2021

When running engin_executePayload, CL might trigger EL to sync. This might be a huge sync that takes a long time or it could be a short-range sync of filling in a few blocks.

In #84, we discussed potentially adding some notion of how long EL can take to retrieve data from the network before it decides it is SYNCING and can't respond with VALID/INVALID.

This brings in additional complexity and only optimizes these (likely) rare cases when EL and CL have a block or two inconsistency issue.

I'm leaning toward not adding the note at all, but am dropping this for discussion before a final decision is made.

Some relevant discussion points here -- #84 (comment)

@djrtwo
Copy link
Contributor Author

djrtwo commented Jan 13, 2022

closing this as deemed unnecessary

@djrtwo djrtwo closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant