Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the semantics lib to analyzer. #207

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Jan 28, 2021

This renames the fe-semantics library to fe-analyzer.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

Copy link
Collaborator

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I think it is needed for this cahnge but these kind of changes could go into a 207.internal.md to get covered in the internal section of the release notes (which is for developers working on the Fe codebase...which isn't a large group yet so feel free to ignore 😅 )

@codecov-io
Copy link

Codecov Report

Merging #207 (d03ed4a) into master (e108a74) will increase coverage by 16.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #207       +/-   ##
===========================================
+ Coverage   77.50%   94.27%   +16.76%     
===========================================
  Files          47       49        +2     
  Lines        3308     3355       +47     
===========================================
+ Hits         2564     3163      +599     
+ Misses        744      192      -552     
Impacted Files Coverage Δ
analyzer/src/errors.rs 77.27% <ø> (ø)
analyzer/src/namespace/events.rs 100.00% <ø> (ø)
analyzer/src/namespace/operations.rs 90.32% <ø> (ø)
analyzer/src/namespace/scopes.rs 95.29% <ø> (ø)
analyzer/src/namespace/types.rs 85.58% <ø> (ø)
analyzer/src/traversal/_utils.rs 100.00% <ø> (ø)
analyzer/src/traversal/assignments.rs 96.87% <ø> (ø)
analyzer/src/traversal/contracts.rs 100.00% <ø> (ø)
analyzer/src/traversal/declarations.rs 95.65% <ø> (ø)
analyzer/src/traversal/expressions.rs 95.51% <ø> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e108a74...d03ed4a. Read the comment docs.

@g-r-a-n-t g-r-a-n-t merged commit 70fe145 into ethereum:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants