p2p/nodestate: fix deadlock during shutdown of les server (#21927)

This PR fixes a deadlock reported here: #21925 The cause is that many operations may be pending, but if the close happens, only one of them gets awoken and exits, the others remain waiting for a signal that never comes.
ethereum · Nov 30, 2020 · e7db1db · e7db1db
1 parent a1ddd9e
commit e7db1db
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/p2p/nodestate/nodestate.go b/p2p/nodestate/nodestate.go
@@ -725,7 +725,7 @@ func (ns *NodeStateMachine) opFinish() {
 	}
 	ns.opPending = nil
 	ns.opFlag = false
-	ns.opWait.Signal()
+	ns.opWait.Broadcast()
 }
 
 // Operation calls the given function as an operation callback. This allows the caller