Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestClientNotificationStorm is broken on FreeBSD #22314

Closed
gballet opened this issue Feb 11, 2021 · 1 comment · Fixed by #22316
Closed

TestClientNotificationStorm is broken on FreeBSD #22314

gballet opened this issue Feb 11, 2021 · 1 comment · Fixed by #22316
Assignees
Labels

Comments

@gballet
Copy link
Member

gballet commented Feb 11, 2021

System information

Geth version: cffdc43954c5f5fa4364ddfbf3881cdfeb667fb7
OS & Version: FreeBSD

Expected behaviour

TestClientNotificationStorm passes on FreeBSD

Actual behaviour

> go run build/ci.go test -coverage ./rpc/
>>> /usr/local/go/bin/go test -ldflags -X main.gitCommit=cffdc43954c5f5fa4364ddfbf3881cdfeb667fb7 -X main.gitDate=20210211 -p 1 -covermode=atomic -cover ./rpc/
--- FAIL: TestClientNotificationStorm (2.40s)
    client_test.go:425: didn't get expected error
FAIL
coverage: 84.8% of statements
FAIL	github.com/ethereum/go-ethereum/rpc	6.768s
FAIL
util.go:47: exit status 1
exit status 1

Steps to reproduce the behaviour

go run build/ci.go test -coverage ./rpc/

@gballet gballet self-assigned this Feb 11, 2021
@gballet gballet changed the title FreeBSD tests are broken TestClientNotificationStorm is broken on FreeBSD Feb 11, 2021
@gballet
Copy link
Member Author

gballet commented Feb 11, 2021

Looks like FreeBSD is able to handle more subscription than other OSes, I can fix the test by setting the limit to 50k in client_test.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant