Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, eth: unship EIP 2315 #22414

Merged
merged 2 commits into from
Mar 7, 2021
Merged

core, eth: unship EIP 2315 #22414

merged 2 commits into from
Mar 7, 2021

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Mar 2, 2021

Posted without comments.

@lightclient lightclient mentioned this pull request Mar 3, 2021
Closed
@karalabe
Copy link
Member Author

karalabe commented Mar 4, 2021

Decision was against removing this EIP.

@karalabe karalabe closed this Mar 4, 2021
@karalabe karalabe reopened this Mar 5, 2021
@winsvega
Copy link
Contributor

winsvega commented Mar 6, 2021 •
edited
Loading

when merge?

@karalabe
Copy link
Member Author

karalabe commented Mar 6, 2021 via email

@winsvega
Copy link
Contributor

winsvega commented Mar 6, 2021 •
edited
Loading

@qbzzt Ori did a test on this PR

ethereum/tests#798

holiman
holiman approved these changes Mar 6, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@holiman holiman mentioned this pull request Mar 7, 2021
Merged
@karalabe karalabe added this to the 1.10.1 milestone Mar 7, 2021
@karalabe karalabe merged commit 658cb9f into ethereum:master Mar 7, 2021
This was referenced Mar 9, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@meowsbits meowsbits mentioned this pull request Mar 15, 2021
Closed
@meowsbits
Copy link
Contributor

Decision was against removing this EIP.

Where was this decision made? Can someone provide a link?

@karalabe
Copy link
Member Author

There was a decision against the decision of removing this EIP XD. Final Berlin spec removed it.

@meowsbits
Copy link
Contributor

I found the AllCoreDevs call Ethereum Core Devs Meeting #107​ [2021-03-05] (via ethereum/execution-specs@7d3d203) where this is discussed and apparently the decision is ultimately reached: https://youtu.be/xWfR-WxjmYg?t=223.

@quorumbot quorumbot mentioned this pull request Jan 28, 2022
Closed
9 tasks
@quorumbot quorumbot mentioned this pull request Apr 8, 2022
Merged
9 tasks
@benbaley
Copy link

How can we guarantee the correct execution of historical transactions during full sync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.
5 participants
@karalabe @winsvega @meowsbits @benbaley @holiman