Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address generated via json-rpc ->personal_newAccount should be EIP-55 encoded #24406

Closed
benbaley opened this issue Feb 16, 2022 · 5 comments
Closed

address generated via json-rpc ->personal_newAccount should be EIP-55 encoded #24406

benbaley opened this issue Feb 16, 2022 · 5 comments
Labels
area:rpc good first issue

Comments

@benbaley
Copy link

Wouldn't it be better to return the address with checksum？
@holiman
Copy link
Contributor

holiman commented Feb 16, 2022

Yes, I agree

@ligi ligi changed the title [Question] Why is the address generated via json-rpc ->personal_newAccount in hex instead of EIP-55? address generated via json-rpc ->personal_newAccount should be EIP-55 encoded Feb 17, 2022
@ligi ligi added area:rpc and removed type:docs labels Feb 17, 2022
@benbaley benbaley mentioned this issue Feb 17, 2022
Closed
@alexmylonas alexmylonas mentioned this issue Mar 24, 2023
Merged
@amirrmonfared
Copy link

@alexmylonas are working on this issue? if not please tell me then I can begin on your work :)

@alexmylonas
Copy link
Contributor

@alexmylonas are working on this issue? if not please tell me then I can begin on your work :)

Yeap just pushed a commit addressing PR's feedback!

@makinje16
Copy link

Scrolling through "good first issues" and it looks like this issue was fixed with the merge of #26973. Can this be closed now?

@holiman
Copy link
Contributor

holiman commented Dec 1, 2023

Can this be closed now?

Yup, thanks!

@holiman holiman closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rpc good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ligi @holiman @makinje16 @alexmylonas @MariusVanDerWijden @benbaley @amirrmonfared and others