Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn the user when the path name is too long for the ipc endpoint on linux #18330

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Warn the user when the path name is too long for the ipc endpoint on linux #18330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb2ec9
added the log.warn for the ipc endpoint
MartinDawson Dec 18, 2018
e97307b
rpc: get max socket path length from OS headers
gballet Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions rpc/ipc_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,31 @@ package rpc

import (
"context"
"fmt"
"net"
"os"
"path/filepath"

"github.com/ethereum/go-ethereum/log"
)

/*
#include <sys/un.h>

int max_socket_path_size() {
struct sockaddr_un s;
return sizeof(s.sun_path);
}
*/
import "C"

// ipcListen will create a Unix socket on the given endpoint.
func ipcListen(endpoint string) (net.Listener, error) {
if len(endpoint) > int(C.max_socket_path_size()) {
log.Warn(fmt.Sprintf("The ipc endpoint is longer than %d characters. ", C.max_socket_path_size()),
"endpoint", endpoint)
}

// Ensure the IPC path exists and remove any previous leftover
if err := os.MkdirAll(filepath.Dir(endpoint), 0751); err != nil {
return nil, err
Expand Down