eth: skip transaction announcer goroutine on eth<65 #21032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
May 6, 2020
7 tasks
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
…to be blocked (ethereum#1484) * (Cherry-pick from upstream) Merge pull request ethereum#21032 from karalabe/skip-announce-goroutine-eth64 eth: skip transaction announcer goroutine on eth<65 * Update eth65 -> celo66 in cherry-picked code * (Cherry-pick form upstream) eth: don't block if transaction broadcast loop fails (ethereum#21255) * eth: don't block if transaction broadcast loop is returned * eth: kick out peer if we failed to send message * eth: address comment Conflicts: eth/peer.go Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: gary rong <garyrong0905@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since implementing tx announcement, we've spun up a goroutine even for
eth<65peers. Whilst they are harmless, they make debugging goroutine leaks hard as they fill up the stack traces with noise. This PR just doesn't spin them up n the first place. The shutdown is fine as there's no individual tracking and the async announce sends are already properly limited toeth65+.