eth/downloader: fix rollback issue on short chains #21472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8cbdc86#diff-c2fa15e758e986688c646459d8970a50R1501-R1504 , the rollback mechanism was changed, from beign a slice of hashes to being a number.
The change also cause a regression, if the number is smaller than
fsHeaderSafetyNet
, then the rollback will be0
, and thesethead
won't happen. This causes some spurious test failures,