les: les/4 minimalistic version #21909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
reviewed
Dec 1, 2020
9 tasks
les/peer.go
Outdated
| disableTxLookup := server.handler.blockchain.TxLookupLimit() != 0 | ||
| if disableTxLookup && p.version < lpv4 { | ||
| recentTx := server.handler.blockchain.TxLookupLimit() | ||
| if recentTx > 0 { // 0 means no limit (all txs available) |
There was a problem hiding this comment.
Can we put these number in the protocol file and use the constants? It's a bit weird to hardcode the number here
There was a problem hiding this comment.
Sorry one more nitpicks, can we replace the 1 with a constant? It's better to define in the protocol that 1 means disabled.
rjl493456442
approved these changes
Dec 14, 2020
les/peer.go
Outdated
| disableTxLookup := server.handler.blockchain.TxLookupLimit() != 0 | ||
| if disableTxLookup && p.version < lpv4 { | ||
| recentTx := server.handler.blockchain.TxLookupLimit() | ||
| if recentTx > 0 { // 0 means no limit (all txs available) |
There was a problem hiding this comment.
Sorry one more nitpicks, can we replace the 1 with a constant? It's better to define in the protocol that 1 means disabled.
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows tx unindexing in les/4 light server mode.
A few more upgrades might be added to les/4 but the goal is to keep the number of changes low while satisfying the requirements stated in #21876
Most of the upgrades needed for incentivization (including UDP communication) should go into les/5.
Features that might be added to the les/4 upgrade (up for debate):
Note: the metainfo channel upgrade is needed for incentivization and therefore could also go into les/5. The reason I added it here is because it can be added separately from everything else and it would make the next upgrade easier (less changes at once). I think with the rest of the changes postponed this upgrade would still be relatively low risk if we add the metainfo and it would help my progress but if there is a good reason then we can leave it out.