Convert int/hash values from context into js object #23108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamberman
requested review from
holiman,
karalabe and
rjl493456442
as code owners
karalabe
reviewed
Jun 24, 2021
eth/tracers/tracer.go
Outdated
| jst.vm.PushInt(val) | ||
|
|
||
| case common.Hash: | ||
| jst.vm.PushString(val.Hex()) |
There was a problem hiding this comment.
Hmm, wondering if this should be similar to the common.Address part:
ptr := jst.vm.PushFixedBuffer(32)
copy(makeSlice(ptr, 32), val[:])
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…ereum#23108) * Convert int/hash values from context into js object * Use js fixed buffer Co-authored-by: William <william.berman@coinbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracer context now has
intandHashtypes. They need to be converted before they're pushed on the js stack.