-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql: add storage slots to access list #23650
Conversation
graphql/graphql.go
Outdated
@@ -440,9 +440,13 @@ func (t *Transaction) AccessList(ctx context.Context) (*[]*AccessTuple, error) { | |||
accessList := tx.AccessList() | |||
ret := make([]*AccessTuple, 0, len(accessList)) | |||
for _, al := range accessList { | |||
var sKeys []common.Hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
al := al
would also fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be even better to change the type of AccessTuple.storageKeys
to non-pointer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, PTAL
4379773
to
7752cc3
Compare
I'm not really certain why it didn't work previously, but for some reason, this fixes it.
Without this PR:
With this PR: