-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulators: integrate les light client into the RPC test suite #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does this require that other PR or can this be merged separately? |
@holiman The problem of the previous PR(#424) is that: LES Server has this property that it will reject all client connections by default if it's not synced yet. While the indicator of "node synced" is setup by (1) inserting a new block (2) start mining. For (1) it's impossible/ugly in the hive test suite, we insert the pre-configured blocks by offline command and no more block involved. So the indicator won't be marked forever. For (2) it's feasible to start mining with So I add a new feature in Geth, so that LES server can start serving even the les server is not synced. It can work perfectly with new version Geth, but it won't work for the legacy Geths. So it blocks the PR. We can either filter out the legacy Geth version for LES testing or use approach (2) so that it can work for all Geths. What's your option about it? And for this RPC test suite for LES, it's based on the previous one. If the previous one can be merged, we can just merge this one. cc @fjl |
I think we need to wait a couple more days before merging this. I'm working on integrating the client roles from PR #443 at the moment. When this is done, we can remove the client name logic in this PR and just define roles for les-capable clients. |
It's a following PR based on #424