-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to have "Considered for Inclusion" reset after each upgrade #295
Comments
Yes, this makes a lot of sense, I would support this.
Not sure if it is just me, but I am personally not getting along so well with these GitHub Projects overviews and I have some tendency to overlook content which is organized by this tool. Just as some low-level feedback, if there are more voices like this one might want to change here. |
I kind of agree. What would you prefer to see? A |
Yes. Also a lot more transparent regarding the work process with PRs tracking the changes and allow for discussion. Yes, I am just live-thinking a bit, I think especially this last point is pretty important. I am just realizing that I would trust this list a lot more if it wouldn't be just items moved around at some PIT from someone with admin permissions but instead has some transparent change process (meant as structural criticism being totally independent from the persons actually doing it). If it is in the repo than it will likely also become more of an official point of reference leaving the character of an internal planning tool (not sure but if this planning site actually is made more for your internal tracking to not loose oversight. In that case you might also want to keep as-is). If you want to change this it might also become a good habit to just do a PR after each ACD wrapping up and integrate the things discussed. Think this would make things super transparent and beautiful, if one can always trace and reference the condensed accepted changes on CFI from a call. Maybe you want to ask on next ACD if this format change makes sense since the topic is already on the agenda? Just had a look at the current content structure, I think it would have some value to keep this generally on one page (first thought if a) a new directory So I would have a first tendency to something simple like: /network-upgrades/considered-for-inclusion.mdSome short intro text ("This is the currently considered list of EIPs..., see also CFI process [link]") Targeted Hardfork: London (this is important to have the context on future linking of old change PRs) Considered for Inclusion (CFI)
(not sure if the "Authors" list is necessary here) "Devnets" (i.e. YOLO, Aleut, etc.)TestnetsMainnetAnd maybe it's worth to have a separate /network-upgrades/considered-for-inclusion-archive.mdSome short intro text Berlin
Does this make sense? Just as some first inspiration for a possible structure. 😄 |
Also //cc-ing here @poojaranjan and @axic for notice and eventual feedback |
@holgerd77 thanks for the comment! Generally agreed with a
|
Also, for clarity, when we discuss this on AllCoreDevs, we need to get confirmation that the following EIPs are CFI for London:
Alongside the two that are already included (1559 & 3238). We should also agree on the status for EIP-3198 (BASE FEE opcode): we agreed to put it in Aleut, but it was not clear what the associated status would be. |
What would be process for getting an EIP that has had its CFI status cleared (after an upgrade) back into CFI status? Would that be the responsibility of the EIP champion, or is there another (possibly collective/ACD?) role that gathers EIPs from those available to be restored to CFI status prior to an upgrade? Just wondering as it kind of implies that in some cases an EIP champion may be required to re-state the case for the EIP on multiple occasions. I personally think that would be a good thing as the discussion around inclusion should always be contextual, and the context changes over time - i.e. what is needed for the overall roadmap at that point in time. This may help to avoid scenarios like 2315 for Berlin. |
@shanelightowler yes, I think the champion should re-state that they want their EIP considered for inclusion again for a new upgrade. The champion could change from upgrade to upgrade, but I don't want "AllCoreDevs" to own this because if the EIP does not have at least a strong champion, that's a very strong signal it may not be valuable enough. It's not a huge ask to re-state this, and it already happened naturally for EIP-2537, see: #269 |
Opened a separate issue to discuss the markdown vs. Github project stuff in the eth1-specs repo: ethereum/execution-specs#23 |
We agreed on ACD111 to do this 🎉 ! I will close this issue and update the CFI project board. |
As part of separating the EIP process from the network upgrade process, a set of stages were created to track progress of EIPs towards mainnet, they are:
CFI is intended for core developers to signal support for an idea before it is fully fleshed out. Given how much things change between network upgrades, I propose that this status resets between upgrades (i.e. an EIP which was CFI for Berlin would not automatically be CFI for London). We already implicitly do this, but I wanted to ask before going ahead and archiving past CFI EIPs.
The CFI list is tracked here. The pre-London/Shanghai list includes the following EIPs: 663, 2711 (likely superseded by 3074), 2398, 2046, 1985, 1380. EIP-2537 was also CFI pre-Berlin, but it had enough interest for someone to propose it for London. IMO that should be the minimum bar we expect to move something over to CFI again for the next upgrade.
Doing this will help keep the eth1-specs repo clean and not have stagnant EIPs pile up in the CFI column.
The text was updated successfully, but these errors were encountered: