Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expectation of node in test portal_historyRoutingTableInfo of simulation ts-sim-test #122

Open
kdeme opened this issue Dec 8, 2023 · 0 comments

Comments

@kdeme
Copy link
Collaborator

kdeme commented Dec 8, 2023

The portal_historyRoutingTableInfo test launches Portal ping message in both directions of all the tested nodes.

Next it will call portal_historyRoutingTableInfo to see if all nodes have the other nodes in their routing tables.

However, an ENR only gets transmitted in a discv5 handshake message, and only the ENR of the requesting side is send.
This means that ENR's do not get transferred in all directions in this test scenario. This is why currently tests with Fluffy will fail this test scenario.

I'm curious what other clients do here to make this test pass. Do they actively send a FindNodes request to get this ENR (seems like something that could still fail in this test due to race conditions)? Or do they just simply add the ENR that is passed along the portal_historyPing method (Not really specified behaviour) to the routing table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant