Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portal-hive nodes have access to external networks, causing test contamination #65

Open
KolbyML opened this issue Jul 19, 2023 · 2 comments
Open

portal-hive nodes have access to external networks, causing test contamination #65

KolbyML opened this issue Jul 19, 2023 · 2 comments

Comments

@KolbyML
Copy link
Member

KolbyML commented Jul 19, 2023 

IpV4 UDP Socket: Some(194.33.40.238:9102)
IpV4 UDP Socket: Some(194.33.40.238:9101)

I was trying to work on tests and I found that when I ran fluffly it was connecting to bootstrap nodes. This has the possibility to contaminate tests. This doesn't mean we should change fluffy. But instead make it so the docker nodes used in simulaters are isolated per test.
@kdeme
Copy link
Collaborator

kdeme commented Jul 19, 2023

3 weeks ago I made a change to fluffy so that it default connects to the public testnet (default uses those bootstrap nodes).
This can be disabled with the --network option. I can make a PR to fix that.

Not saying that we should not isolate the tests, that sounds like a good practise.

@KolbyML
Copy link
Member Author

KolbyML commented Jul 19, 2023

I am down for a quick fix for the time being, that PR would be nice

@kdeme kdeme mentioned this issue Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kdeme @KolbyML and others